tengqm commented on code in PR #5652:
URL: https://github.com/apache/gravitino/pull/5652#discussion_r1856683693
##########
core/src/main/java/org/apache/gravitino/listener/FilesetEventDispatcher.java:
##########
@@ -96,6 +104,10 @@ public Fileset createFileset(
String storageLocation,
Map<String, String> properties)
throws NoSuchSchemaException, FilesetAlreadyExistsException {
+ FilesetInfo createFileRequest =
+ new FilesetInfo(ident.name(), comment, type, storageLocation,
properties, null);
+ eventBus.dispatchEvent(
+ new CreateFilesetPreEvent(PrincipalUtils.getCurrentUserName(), ident,
createFileRequest));
Review Comment:
```suggestion
FilesetInfo fileInfo =
new FilesetInfo(ident.name(), comment, type, storageLocation,
properties, null);
eventBus.dispatchEvent(
new CreateFilesetPreEvent(PrincipalUtils.getCurrentUserName(),
ident, fileInfo));
```
##########
core/src/main/java/org/apache/gravitino/listener/api/event/CreateFilesetPreEvent.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.listener.api.event;
+
+import org.apache.gravitino.NameIdentifier;
+import org.apache.gravitino.annotation.DeveloperApi;
+import org.apache.gravitino.listener.api.info.FilesetInfo;
+
+/** Represents an event triggered before creating a fileset. */
+@DeveloperApi
+public class CreateFilesetPreEvent extends FilesetPreEvent {
+ private final FilesetInfo createFilesetRequest;
+
+ public CreateFilesetPreEvent(
+ String user, NameIdentifier identifier, FilesetInfo
createFilesetRequest) {
+ super(user, identifier);
+ this.createFilesetRequest = createFilesetRequest;
+ }
+
+ /**
+ * Retrieves the create fileset request.
+ *
+ * @return A {@link FilesetInfo} instance encapsulating the comprehensive
details of create
+ * fileset request.
+ */
+ public FilesetInfo createFilesetRequest() {
+ return createFilesetRequest;
Review Comment:
What you are returning here is not the full set of parameters for a
CreateFileset request, so the info you retrieved should be a filesetInfo as the
return type of the function indicates.
```suggestion
return fileInfo;
```
##########
core/src/main/java/org/apache/gravitino/listener/FilesetEventDispatcher.java:
##########
@@ -32,16 +32,22 @@
import org.apache.gravitino.file.FilesetChange;
import org.apache.gravitino.listener.api.event.AlterFilesetEvent;
import org.apache.gravitino.listener.api.event.AlterFilesetFailureEvent;
+import org.apache.gravitino.listener.api.event.AlterFilesetPreEvent;
import org.apache.gravitino.listener.api.event.CreateFilesetEvent;
import org.apache.gravitino.listener.api.event.CreateFilesetFailureEvent;
+import org.apache.gravitino.listener.api.event.CreateFilesetPreEvent;
import org.apache.gravitino.listener.api.event.DropFilesetEvent;
import org.apache.gravitino.listener.api.event.DropFilesetFailureEvent;
+import org.apache.gravitino.listener.api.event.DropFilesetPreEvent;
import org.apache.gravitino.listener.api.event.GetFileLocationEvent;
import org.apache.gravitino.listener.api.event.GetFileLocationFailureEvent;
+import org.apache.gravitino.listener.api.event.GetFileLocationPreEvent;
import org.apache.gravitino.listener.api.event.ListFilesetEvent;
import org.apache.gravitino.listener.api.event.ListFilesetFailureEvent;
+import org.apache.gravitino.listener.api.event.ListFilesetPreEvent;
import org.apache.gravitino.listener.api.event.LoadFilesetEvent;
import org.apache.gravitino.listener.api.event.LoadFilesetFailureEvent;
+import org.apache.gravitino.listener.api.event.LoadFilesetPreEvent;
Review Comment:
Is `import org.apache.gravitino.listener.api.event.*` anti-pattern thus
discouraged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
