diqiu50 commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1857684454
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/00011_row.sql:
##########
@@ -68,23 +68,23 @@ FROM (
INSERT INTO source_tb1 VALUES (1, 'Alice'), (1, 'Alice'), (2, 'Bob');
-INSERT INTO test_row_basic SELECT ROW(id, name) FROM source_tb1;
+INSERT INTO tb01 SELECT ROW(id, name) FROM source_tb1;
-SELECT person.id, COUNT(*) FROM test_row_basic GROUP BY person.id ORDER BY
person.id;
+SELECT person.id, COUNT(*) FROM tb01 GROUP BY person.id ORDER BY person.id;
-DROP TABLE gt_hive.gt_row_db1.test_row_basic;
+DROP TABLE gt_hive.gt_row_db1.tb01;
DROP TABLE gt_hive.gt_row_db1.source_tb1;
-DROP TABLE gt_hive.gt_row_db1.test_nested_row;
+DROP TABLE gt_hive.gt_row_db1.tb02;
-DROP TABLE gt_hive.gt_row_db1.test_mixed_row;
+DROP TABLE gt_hive.gt_row_db1.tb03;
DROP TABLE gt_hive.gt_row_db1.source_tb2;
DROP TABLE gt_hive.gt_row_db1.source_tb3;
-DROP TABLE gt_hive.gt_row_db1.test_row_in_array_map;
+DROP TABLE gt_hive.gt_row_db1.tb04;
Review Comment:
The original name is Ok. Why do you change it?
##########
trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/trino-remote/init.sh:
##########
@@ -26,13 +26,13 @@ cp "$trino_conf_dir/config/config.properties"
/etc/trino/config.properties
cp "$trino_conf_dir/config/jvm.config" /etc/trino/jvm.config
cp "$trino_conf_dir/config/log4j2.properties" /etc/trino/log4j2.properties
cp "$trino_conf_dir/config/catalog/gravitino.properties"
/etc/trino/catalog/gravitino.properties
+cp /usr/lib/trino/plugin/mysql/mysql-connector-j-8.2.0.jar
/usr/lib/trino/plugin/iceberg
#
Review Comment:
Why don't you copy the pg connector
##########
LICENSE:
##########
@@ -290,6 +290,7 @@
Trino
./integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/CloseableGroup.java
./trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/hive/SortingColumn.java
+
./trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/00012_format.sql
Review Comment:
Why we need to add this line?
##########
trino-connector/integration-test/trino-test-tools/trino-cascading-env/docker-compose.yaml:
##########
@@ -69,6 +98,8 @@ services:
depends_on:
mysql:
condition: service_healthy
+ hive:
+ condition: service_healthy
Review Comment:
Add the pg healthy check
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryIT.java:
##########
@@ -131,6 +132,23 @@ public void runOneTestSetWithCatalog(
TrinoQueryRunner queryRunner = new
TrinoQueryRunner(TrinoQueryITBase.trinoUri);
executeSqlFile(testSetDirName, catalogPrefix + "prepare.sql", queryRunner,
catalog);
+ if (new File(ITUtils.joinPath(testSetDirName, catalogPrefix +
"cascading_test.sql")).exists()) {
+ Awaitility.await()
+ .atMost(30, TimeUnit.SECONDS)
+ .pollInterval(1, TimeUnit.SECONDS)
+ .until(
+ () -> {
+ try {
+ executeSqlFile(
+ testSetDirName, catalogPrefix + "cascading_test.sql",
queryRunner, catalog);
+ return true;
+ } catch (Exception e) {
+ LOG.error("Failed to run query using trino cascading
connector", e);
+ return false;
+ }
+ });
+ }
+
Review Comment:
I think that is not a good solution, you can create a new issue to solve
this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
