mchades commented on code in PR #5646:
URL: https://github.com/apache/gravitino/pull/5646#discussion_r1857896650
##########
clients/client-python/gravitino/api/expressions/named_reference.py:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
> Why do we call this a named reference?
It represents a reference to a field/column by its name, most common way to
refer to columns in SQL: `SELECT name FROM table`
> Is there a case where a reference has no name?
Yes, examples include:
- Positional references: `SELECT $1`
- Expression results: `SELECT (a + b)`
- Anonymous subquery columns
> Do we have to differentiate these two types of references?
We currently don't have `UnnamedReference` in Gravitino because we haven't
encountered the usage scenarios.
So my suggestion is to keep it as it is like Java implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
