jerryshao commented on code in PR #5662: URL: https://github.com/apache/gravitino/pull/5662#discussion_r1857892818
########## core/src/main/java/org/apache/gravitino/catalog/ModelNormalizeDispatcher.java: ########## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog; + +import static org.apache.gravitino.catalog.CapabilityHelpers.applyCapabilities; +import static org.apache.gravitino.catalog.CapabilityHelpers.applyCaseSensitive; +import static org.apache.gravitino.catalog.CapabilityHelpers.getCapability; + +import java.util.Map; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.connector.capability.Capability; +import org.apache.gravitino.exceptions.ModelAlreadyExistsException; +import org.apache.gravitino.exceptions.ModelVersionAliasesAlreadyExistException; +import org.apache.gravitino.exceptions.NoSuchModelException; +import org.apache.gravitino.exceptions.NoSuchModelVersionException; +import org.apache.gravitino.exceptions.NoSuchSchemaException; +import org.apache.gravitino.model.Model; +import org.apache.gravitino.model.ModelVersion; + +public class ModelNormalizeDispatcher implements ModelDispatcher { + private final CatalogManager catalogManager; + private final ModelDispatcher dispatcher; + + public ModelNormalizeDispatcher(ModelDispatcher dispatcher, CatalogManager catalogManager) { + this.dispatcher = dispatcher; + this.catalogManager = catalogManager; + } + + @Override + public NameIdentifier[] listModels(Namespace namespace) throws NoSuchSchemaException { + // The constraints of the name spec may be more strict than underlying catalog, + // and for compatibility reasons, we only apply case-sensitive capabilities here. + Namespace caseSensitiveNs = normalizeCaseSensitive(namespace); + NameIdentifier[] identifiers = dispatcher.listModels(caseSensitiveNs); + return normalizeCaseSensitive(identifiers); + } + + @Override + public Model getModel(NameIdentifier ident) throws NoSuchModelException { + // The constraints of the name spec may be more strict than underlying catalog, + // and for compatibility reasons, we only apply case-sensitive capabilities here. + return dispatcher.getModel(normalizeCaseSensitive(ident)); + } + + @Override + public boolean modelExists(NameIdentifier ident) { + // The constraints of the name spec may be more strict than underlying catalog, + // and for compatibility reasons, we only apply case-sensitive capabilities here. + return dispatcher.modelExists(normalizeCaseSensitive(ident)); + } + + @Override + public Model registerModel(NameIdentifier ident, String comment, Map<String, String> properties) + throws ModelAlreadyExistsException { + return dispatcher.registerModel(normalizeNameIdentifier(ident), comment, properties); + } + + @Override + public Model registerModel( + NameIdentifier ident, + String uri, + String[] aliases, + String comment, + Map<String, String> properties) + throws ModelAlreadyExistsException, ModelVersionAliasesAlreadyExistException { + return dispatcher.registerModel( + normalizeNameIdentifier(ident), uri, aliases, comment, properties); + } + + @Override + public boolean deleteModel(NameIdentifier ident) { + // The constraints of the name spec may be more strict than underlying catalog, + // and for compatibility reasons, we only apply case-sensitive capabilities here. + return dispatcher.deleteModel(normalizeCaseSensitive(ident)); + } + + @Override + public int[] listModelVersions(NameIdentifier ident) throws NoSuchModelException { + return dispatcher.listModelVersions(normalizeCaseSensitive(ident)); + } + + @Override + public ModelVersion getModelVersion(NameIdentifier ident, int version) + throws NoSuchModelVersionException { + return dispatcher.getModelVersion(normalizeCaseSensitive(ident), version); + } + + @Override + public ModelVersion getModelVersion(NameIdentifier ident, String alias) + throws NoSuchModelVersionException { + return dispatcher.getModelVersion(normalizeCaseSensitive(ident), alias); + } + + @Override + public boolean modelVersionExists(NameIdentifier ident, int version) { + return dispatcher.modelVersionExists(normalizeCaseSensitive(ident), version); + } + + @Override + public boolean modelVersionExists(NameIdentifier ident, String alias) { + return dispatcher.modelVersionExists(normalizeCaseSensitive(ident), alias); + } + + @Override + public ModelVersion linkModelVersion( + NameIdentifier ident, + String uri, + String[] aliases, + String comment, + Map<String, String> properties) + throws NoSuchModelException, ModelVersionAliasesAlreadyExistException { + return dispatcher.linkModelVersion( + normalizeCaseSensitive(ident), uri, aliases, comment, properties); + } + + @Override + public boolean deleteModelVersion(NameIdentifier ident, int version) { + return dispatcher.deleteModelVersion(normalizeCaseSensitive(ident), version); + } + + @Override + public boolean deleteModelVersion(NameIdentifier ident, String alias) { + return dispatcher.deleteModelVersion(normalizeCaseSensitive(ident), alias); + } + + private Namespace normalizeCaseSensitive(Namespace namespace) { + Capability capabilities = getCapability(NameIdentifier.of(namespace.levels()), catalogManager); + return applyCaseSensitive(namespace, Capability.Scope.MODEL, capabilities); + } + + private NameIdentifier normalizeCaseSensitive(NameIdentifier ident) { + Capability capabilities = getCapability(ident, catalogManager); + return applyCaseSensitive(ident, Capability.Scope.MODEL, capabilities); + } + + private NameIdentifier[] normalizeCaseSensitive(NameIdentifier[] idents) { + if (ArrayUtils.isEmpty(idents)) { + return idents; + } + + Capability capabilities = getCapability(idents[0], catalogManager); + return applyCaseSensitive(idents, Capability.Scope.MODEL, capabilities); + } + + private NameIdentifier normalizeNameIdentifier(NameIdentifier ident) { + Capability capability = getCapability(ident, catalogManager); + return applyCapabilities(ident, Capability.Scope.TOPIC, capability); Review Comment: Sorry, just a typo, I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
