justinmclean commented on PR #5688: URL: https://github.com/apache/gravitino/pull/5688#issuecomment-2503085332
@jerryshao / @shaofengshi this is a work in progress, can you confirm this solution is satisfactory? If so I implement it for other entities. There is a downside to using a command map (or any similar solution) like this: - Some functionality is lost e.g. It is no longer possible to update comments and rename a metalake at the same time. We could add a mapping for this combination of flags as well, but the number of combinations could become large when you have multiple flags. e.g. for 4 flags, you would need to add 14 different mappings ( 4 single combinations, 6 double combinations, 3 triple combinations, and 1 of all four) to cover all possible combinations. This is likely only to impact UPDATE commands and is only possibly an issue with the update column command. - It is more strict on input and does not ignore unnecessary tags, previously, any extra unneeded options were ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
