FANNG1 commented on code in PR #5698:
URL: https://github.com/apache/gravitino/pull/5698#discussion_r1861563306
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -296,7 +297,14 @@ private LoadTableResponse injectCredentialConfig(
}
Credential credential =
CredentialUtils.vendCredential(
- credentialProvider, loadTableResponse.tableMetadata().location());
+ credentialProvider,
+ new String[] {
+ loadTableResponse.tableMetadata().location(),
+
loadTableResponse.tableMetadata().property(TableProperties.WRITE_DATA_LOCATION,
""),
Review Comment:
it's odd to pass an empty path if the specific properties is not set, could
you add a check before adding the extra paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
