mchades commented on code in PR #5699:
URL: https://github.com/apache/gravitino/pull/5699#discussion_r1862883301
##########
docs/jdbc-mysql-catalog.md:
##########
@@ -170,12 +170,18 @@ Index[] indexes = new Index[] {
Although MySQL itself does not support table properties, Gravitino offers
table property management for MySQL tables through the `jdbc-mysql` catalog,
enabling control over table features. The supported properties are listed as
follows:
+#### Immutable fields
+
+Gravitino server doesn't allow to change such properties after table creation:
+
| Property Name | Description
| Required | Since
version |
|-------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------|---------------|
| `engine` | The engine used by the table. The default value is
`InnoDB`. For example `MyISAM`, `MEMORY`, `CSV`, `ARCHIVE`, `BLACKHOLE`,
`FEDERATED`, `ndbinfo`, `MRG_MYISAM`, `PERFORMANCE_SCHEMA`. | No | 0.4.0
|
| `auto-increment-offset` | Used to specify the starting value of the
auto-increment field.
| No |
0.4.0 |
-- Doesn't support remove table properties. You can only modify values, not
delete properties.
+#### Cautions
Review Comment:
suggest to use:
```
:::caution
Doesn't support remove table......
:::
```
##########
docs/apache-hive-catalog.md:
##########
@@ -160,6 +152,21 @@ Hive automatically adds and manages some reserved
properties. Users aren't allow
| `EXTERNAL` | Indicates whether the table is external. |
0.2.0 |
| `transient_lastDdlTime` | Used to store the last DDL time of the table. |
0.2.0 |
+#### Immutable fields
+
+Hive doesn't allow to change such properties after table creation:
+
+| Property Name | Description
| Default Value
|
Required | Since version |
+|---------------------|--------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
+| `location` | The location for table storage, such as
`/user/hive/warehouse/test_table`.
| HMS uses the database location as the parent directory by
default.
| No | 0.2.0 |
+| `table-type` | Type of the table. Valid values include
`MANAGED_TABLE` and `EXTERNAL_TABLE`.
| `MANAGED_TABLE`
| No | 0.2.0 |
+| `format` | The table file format. Valid values include
`TEXTFILE`, `SEQUENCEFILE`, `RCFILE`, `ORC`, `PARQUET`, `AVRO`, `JSON`, `CSV`,
and `REGEX`. | `TEXTFILE`
| No | 0.2.0 |
+| `input-format` | The input format class for the table, such as
`org.apache.hadoop.hive.ql.io.orc.OrcInputFormat`.
| The property `format` sets the default value
`org.apache.hadoop.mapred.TextInputFormat` and can change it to a different
default. | No | 0.2.0 |
+| `output-format` | The output format class for the table, such as
`org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat`.
| The property `format` sets the default value
`org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat` and can change it
to a different default. | No | 0.2.0 |
+| `serde-lib` | The serde library class for the table, such as
`org.apache.hadoop.hive.ql.io.orc.OrcSerde`.
| The property `format` sets the default value
`org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe` and can change it to a
different default. | No | 0.2.0 |
+| `serde.parameter.` | The prefix of the serde parameter, such as
`"serde.parameter.orc.create.index" = "true"`, indicating `ORC` serde lib to
create row indexes | (none)
| No | 0.2.0 |
+| `serde-name` | The name of the serde
|
| No
| 0.2.0 |
Review Comment:
FYI:
https://github.com/apache/gravitino/blob/7a42199a5fcaa02eaa8053cfec5b6f7b3dab3850/catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveTablePropertiesMetadata.java#L96-L97
##########
docs/apache-hive-catalog.md:
##########
@@ -140,15 +140,7 @@ Since 0.6.0-incubating, the data types other than listed
above are mapped to Gra
Table properties supply or set metadata for the underlying Hive tables.
The following table lists predefined table properties for a Hive table.
Additionally, you can define your own key-value pair properties and transmit
them to the underlying Hive database.
-| Property Name | Description
| Default Value
|
Required | Since version |
Review Comment:
how about adding columns of `reserved` and `immutable` to the table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
