shaofengshi commented on code in PR #4600:
URL: https://github.com/apache/gravitino/pull/4600#discussion_r1864045246
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java:
##########
@@ -64,7 +65,7 @@ public class IcebergConfig extends Config implements
OverwriteDefaultConfig {
.doc("The uri config of the Iceberg catalog")
.version(ConfigConstants.VERSION_0_2_0)
.stringConf()
- .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
+ .checkValue(TypeValidator::isJdbcURL,
ConfigConstants.JDBC_URL_INVALID_ERROR_MSG)
Review Comment:
The IcebergConfig should not be changed, because the URI here might be
another style (not JDBC url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
