unknowntpo commented on code in PR #110:
URL:
https://github.com/apache/gravitino-playground/pull/110#discussion_r1868535855
##########
init/hive/init.sh:
##########
@@ -21,7 +21,6 @@
sed -i '$d' /usr/local/sbin/start.sh
sed -i '$d' /usr/local/sbin/start.sh
cp /tmp/hive/core-site.xml /tmp/hadoop-conf
-sed -i "s|hdfs://localhost:9000|hdfs://${HIVE_HOST_IP}:9000|g"
/usr/local/hive/conf/hive-site.xml
/bin/bash /usr/local/sbin/start.sh
Review Comment:
I think we don't need to add this line, because in `start.sh`, It has
already used `sed` to replace it with `$(hostname)`.
```
sed -i "s/__REPLACE__HOST_NAME/$(hostname)/g" ${HIVE_CONF_DIR}/hive-site.xml
```
https://github.com/apache/gravitino/blob/branch-0.7/dev/docker/hive/start.sh#L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
