tengqm commented on code in PR #5717:
URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868582426
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -50,6 +50,7 @@ public class GravitinoOptions {
public static final String ROLE = "role";
public static final String AUDIT = "audit";
public static final String FORCE = "force";
+ public static final String COLUMNFILE = "csv";
Review Comment:
My suggestion was that we may want to name an option by its purpose rather
than its implementation (file format here). Consider that in the future, you
may want to add another option where a CSV file happens to be a good fit. We
will get trapped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
