yuqi1129 commented on code in PR #5753:
URL: https://github.com/apache/gravitino/pull/5753#discussion_r1870814176
##########
api/src/main/java/org/apache/gravitino/credential/S3SecretKeyCredential.java:
##########
@@ -44,13 +45,17 @@ public class S3SecretKeyCredential implements Credential {
* @param secretAccessKey The S3 static secret access key.
*/
public S3SecretKeyCredential(String accessKeyId, String secretAccessKey) {
- Preconditions.checkNotNull(accessKeyId, "S3 access key Id should not
null");
- Preconditions.checkNotNull(secretAccessKey, "S3 secret access key should
not null");
-
+ validate(accessKeyId, secretAccessKey, 0);
Review Comment:
> do you have a strong option to change this? it's part of the credential API
Because different people have differing viewpoints about which numbers
represent permanence, it's just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
