tengqm commented on code in PR #5773:
URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872395461
##########
catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java:
##########
@@ -43,6 +45,12 @@ public class MysqlTypeConverter extends JdbcTypeConverter {
@Override
public Type toGravitino(JdbcTypeBean typeBean) {
switch (typeBean.getTypeName().toLowerCase()) {
+ case BIT:
+ case BIT_UNSIGNED:
+ if (typeBean.getColumnSize() == null ||
Integer.parseInt(typeBean.getColumnSize()) <= 1) {
Review Comment:
The fact that `getColumnSize()` returns a string is a surprise to me.
Anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
