tengqm commented on code in PR #5761:
URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872397682
##########
catalogs/catalog-jdbc-mysql/src/test/java/org/apache/gravitino/catalog/mysql/integration/test/CatalogMysqlIT.java:
##########
@@ -196,10 +197,10 @@ private void createCatalog() throws SQLException {
Catalog loadCatalog = metalake.loadCatalog(catalogName);
Assertions.assertEquals(createdCatalog, loadCatalog);
- catalog = loadCatalog;
+ return loadCatalog;
}
- private void createSchema() {
+ private void createSchema(Catalog catalog, String schemaName) {
Review Comment:
I don't think you need to pass Catalog here.
`createSchema()` is a private function, and it can access `catalog` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
