shaofengshi commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872668929
########## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RevokePrivilegesFromRole.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cli.commands; + +import java.util.ArrayList; +import java.util.List; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.authorization.Privilege; +import org.apache.gravitino.cli.CommandEntities; +import org.apache.gravitino.cli.ErrorMessages; +import org.apache.gravitino.cli.Privileges; +import org.apache.gravitino.client.GravitinoClient; +import org.apache.gravitino.dto.authorization.PrivilegeDTO; +import org.apache.gravitino.exceptions.NoSuchMetadataObjectException; +import org.apache.gravitino.exceptions.NoSuchMetalakeException; +import org.apache.gravitino.exceptions.NoSuchRoleException; + +/** Revokes oen or more privileges. */ +public class RevokePrivilegesFromRole extends Command { + + protected final String metalake; + protected final String role; + protected final String entity; + protected final String entityType; + protected final String[] privileges; + + /** + * Revokes oen or more privileges. + * + * @param url The URL of the Gravitino server. + * @param ignoreVersions If true don't check the client/server versions match. + * @param metalake The name of the metalake. + * @param role The name of the role. + * @param entity The name of the entity. + * @param entityType The type entity. + * @param privileges The list of privileges. + */ + public RevokePrivilegesFromRole( + String url, + boolean ignoreVersions, + String metalake, + String role, + String entity, + String entityType, + String[] privileges) { + super(url, ignoreVersions); + this.metalake = metalake; + this.entity = entity; + this.entityType = entityType; + this.role = role; + this.privileges = privileges; + } + + /** Revokes oen or more privileges. */ Review Comment: A typo "oen" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
