xloya commented on code in PR #5777: URL: https://github.com/apache/gravitino/pull/5777#discussion_r1877973226
########## clients/client-python/gravitino/dto/responses/credential_response.py: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import List +from dataclasses import dataclass, field +from dataclasses_json import config + +from gravitino.dto.credential_dto import CredentialDTO +from gravitino.dto.responses.base_response import BaseResponse +from gravitino.exceptions.base import IllegalArgumentException + + +@dataclass +class CredentialResponse(BaseResponse): + """Response for credential response.""" + + _credentials: List[CredentialDTO] = field(metadata=config(field_name="credentials")) + + def credentials(self) -> List[CredentialDTO]: + return self._credentials + + def validate(self): + """Validates the response data. + + Raises: + IllegalArgumentException if credentials are None. + """ + if self._credentials is None: Review Comment: It's better to check the length of `List` object too. ########## clients/client-python/gravitino/client/metadata_object_credential_operations.py: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import List +from gravitino.api.credential.supports_credentials import SupportsCredentials +from gravitino.api.credential.credential import Credential +from gravitino.api.metadata_object import MetadataObject +from gravitino.dto.credential_dto import CredentialDTO +from gravitino.dto.responses.credential_response import CredentialResponse +from gravitino.exceptions.handlers.credential_error_handler import ( + CREDENTIAL_ERROR_HANDLER, +) +from gravitino.utils import HTTPClient +from gravitino.utils.credential_utils import CredentialUtils + +logger = logging.getLogger(__name__) + + +class MetadataObjectCredentialOperations(SupportsCredentials): + def __init__( + self, + metalake_name: str, + metadata_object: MetadataObject, + rest_client: HTTPClient, + ): + self._rest_client = rest_client + t = metadata_object.type().value Review Comment: It's better to make this var more meaningful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
