FANNG1 commented on code in PR #5814: URL: https://github.com/apache/gravitino/pull/5814#discussion_r1879221330
########## api/src/main/java/org/apache/gravitino/credential/OSSSecretKeyCredential.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.credential; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.commons.lang3.StringUtils; + +/** OSS secret key credential. */ +public class OSSSecretKeyCredential implements Credential { + + /** OSS secret key credential type. */ + public static final String OSS_SECRET_KEY_CREDENTIAL_TYPE = "oss-secret-key"; + /** The static access key ID used to access OSS data. */ + public static final String GRAVITINO_OSS_STATIC_ACCESS_KEY_ID = "oss-access-key-id"; + /** The static secret access key used to access OSS data. */ + public static final String GRAVITINO_OSS_STATIC_SECRET_ACCESS_KEY = "oss-secret-access-key"; + + private String accessKeyId; + private String secretAccessKey; + + /** + * Constructs an instance of {@link OSSSecretKeyCredential} with the static OSS access key ID and + * secret access key. + * + * @param accessKeyId The OSS static access key ID. + * @param secretAccessKey The OSS static secret access key. + */ + public OSSSecretKeyCredential(String accessKeyId, String secretAccessKey) { + Preconditions.checkNotNull(accessKeyId, "OSS access key Id should not null"); Review Comment: could you reuse `validate` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
