tengqm commented on code in PR #5838:
URL: https://github.com/apache/gravitino/pull/5838#discussion_r1881221970
##########
package-lock.json:
##########
@@ -0,0 +1,6 @@
+{
+ "name": "gravitino",
+ "lockfileVersion": 3,
+ "requires": true,
+ "packages": {}
Review Comment:
This file is committed by accident?
##########
clients/client-python/gravitino/dto/requests/schema_create_request.py:
##########
@@ -42,4 +42,4 @@ def __init__(
def validate(self):
if not self._name:
- raise ValueError('"name" field is required and cannot be empty')
+ raise ValueError('"schema name" field is required and cannot be
empty')
Review Comment:
There is no field name "schema name" ... the revised version is confusing.
##########
clients/client-python/gravitino/dto/requests/catalog_create_request.py:
##########
@@ -63,7 +63,7 @@ def validate(self):
IllegalArgumentException if name or type are not set.
"""
if not self._name:
- raise ValueError('"name" field is required and cannot be empty')
+ raise ValueError('The catalog name is required. Please provide a
valid name when creating the catalog.')
Review Comment:
```suggestion
raise ValueError('The catalog name is required. Please provide a
valid name when creating a catalog.')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
