justinmclean commented on code in PR #5793:
URL: https://github.com/apache/gravitino/pull/5793#discussion_r1881335330
##########
api/src/main/java/org/apache/gravitino/SupportsCatalogs.java:
##########
@@ -98,6 +101,23 @@ Catalog createCatalog(
Map<String, String> properties)
throws NoSuchMetalakeException, CatalogAlreadyExistsException;
+ /**
+ * Create a managed catalog with specified catalog name, type, comment, and
properties.
+ *
+ * @param catalogName the name of the catalog.
+ * @param type the type of the catalog.
+ * @param comment the comment of the catalog.
+ * @param properties the properties of the catalog.
+ * @return The created catalog.
+ * @throws NoSuchMetalakeException If the metalake does not exist.
+ * @throws CatalogAlreadyExistsException If the catalog already exists.
+ */
+ default Catalog createCatalog(
+ String catalogName, Catalog.Type type, String comment, Map<String,
String> properties)
+ throws NoSuchMetalakeException, CatalogAlreadyExistsException {
+ return createCatalog(catalogName, type, null, comment, properties);
Review Comment:
This is out of scope of this PR as it's outside the CLI code or any changes
made by this PR. Best to raise a new issue for it.
##########
api/src/main/java/org/apache/gravitino/credential/GCSTokenCredential.java:
##########
@@ -70,4 +83,11 @@ public Map<String, String> credentialInfo() {
public String token() {
return token;
}
+
+ private void validate(String token, long expireTimeInMs) {
Review Comment:
This is out of scope of this PR as it's outside the CLI code or any changes
made by this PR. Best to raise a new issue for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
