justinmclean commented on code in PR #5843:
URL: https://github.com/apache/gravitino/pull/5843#discussion_r1883079363
##########
common/src/main/java/org/apache/gravitino/dto/requests/MetalakeCreateRequest.java:
##########
@@ -74,6 +74,6 @@ public MetalakeCreateRequest(String name, String comment,
Map<String, String> pr
@Override
public void validate() throws IllegalArgumentException {
Preconditions.checkArgument(
- StringUtils.isNotBlank(name), "\"name\" field is required and cannot
be empty");
+ StringUtils.isNotBlank(name), "\"name\" field is required. Please
provide a valid name for the Metalake. It cannot be empty or only whitespace.");
Review Comment:
The issue with this change is that it changes the Java API, not the
Gravitino CLI. In the Java API context, this error message is correct, in the
CLI context, the message could be more helpful. The change needs to be made in
teh CLI code not in the Java API code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
