FANNG1 commented on code in PR #5801:
URL: https://github.com/apache/gravitino/pull/5801#discussion_r1883134333
##########
bundles/aws-bundle/src/main/java/org/apache/gravitino/s3/credential/S3TokenProvider.java:
##########
@@ -104,6 +104,10 @@ private StsClient createStsClient(S3CredentialConfig
s3CredentialConfig) {
if (StringUtils.isNotBlank(region)) {
builder.region(Region.of(region));
}
+ String stsEndpoint = s3CredentialConfig.stsEndpoint();
+ if (StringUtils.isNotBlank(stsEndpoint)) {
+ builder.endpointOverride(URI.create(stsEndpoint));
Review Comment:
If stsEndpoint is empty, there are two possibilities, 1. user doesn't set it
explicitly. 2. user set an empty string.
How should we handle it? The current logic is don't set sts endpoint for sts
client. it's buggy to throw an exception here, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
