xunliu commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888014303
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##########
@@ -509,6 +538,10 @@ public HiveContainer getKerberosHiveContainer() {
return kerberosHiveContainer;
}
+ public HiveContainer getJdbcHiveContainer() {
Review Comment:
I think it better change `getJdbcHiveContainer()` to
`getSqlBaseAuthHiveContainer()`?
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##########
@@ -65,6 +65,7 @@ public class ContainerSuite implements Closeable {
private static volatile KafkaContainer kafkaContainer;
private static volatile DorisContainer dorisContainer;
private static volatile HiveContainer kerberosHiveContainer;
+ private static volatile HiveContainer jdbcHiveContainer;
Review Comment:
I think it better to change `jdbcHiveContainer` to `sqlBaseAuthHiveContiner`?
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##########
@@ -231,6 +232,34 @@ public void startKerberosHiveContainer() {
}
}
+ public void startJdbcHiveContainer(Map<String, String> envVars) {
Review Comment:
I think it better to change `startJdbcHiveContainer()` to
`startSqlBaseAuthHiveContiner()`?
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##########
@@ -231,6 +232,34 @@ public void startKerberosHiveContainer() {
}
}
+ public void startJdbcHiveContainer(Map<String, String> envVars) {
+ // If you want to enable SQL based authorization, you need both set the
+ // `ENABLE_JDBC_AUTHORIZATION` environment.
+ if (envVars == null
+ || (!Objects.equals(envVars.get(HiveContainer.HIVE_RUNTIME_VERSION),
HiveContainer.HIVE3))
+ || (!envVars.containsKey(HiveContainer.ENABLE_AUTHORIZATION))) {
Review Comment:
I think it better to change `HiveContainer.ENABLE_AUTHORIZATION` to
`HiveContainer.ENABLE_SQL_BASE_AUTHORIZATION`?
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/HiveContainer.java:
##########
@@ -49,6 +49,7 @@ public class HiveContainer extends BaseContainer {
public static final String HIVE_RUNTIME_VERSION = "HIVE_RUNTIME_VERSION";
public static final String HIVE2 = "hive2"; // The Hive container default
version
public static final String HIVE3 = "hive3";
+ public static final String ENABLE_AUTHORIZATION =
"ENABLE_JDBC_AUTHORIZATION";
Review Comment:
I think it better to change `ENABLE_AUTHORIZATION` to
`ENABLE_SQL_BASE_AUTHORIZATION`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
