FANNG1 commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889695868
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##########
@@ -96,43 +105,60 @@ public boolean contains(String catalogName) throws
CatalogException {
return gravitinoCatalogManager.contains(catalogName);
}
- private String getGravitinoCatalogProvider(Configuration configuration) {
+ private BaseCatalogFactory catalogFactory(Map<String, String> configuration)
{
Review Comment:
rename `catalogFactory` to `getCatalogFactory` or something else? single
`catalogFactory` seems a little confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
