justinmclean commented on code in PR #5921:
URL: https://github.com/apache/gravitino/pull/5921#discussion_r1893274859
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -476,6 +476,16 @@ protected void handleUserCommand() {
Command.setAuthenticationMode(auth, userName);
+ if (CommandActions.LIST.equals(command)) {
+ newListUsers(url, ignore, metalake).handle();
+ return;
+ }
+
+ if (Objects.isNull(user)) {
+ System.err.println("User is undefined. Please use --user to specify a
user.");
Review Comment:
I'd keep in line with other error messages and use "Missing --user option."
even if we were to use more verbose error messages I'd avoid saying "undefined".
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -476,6 +476,16 @@ protected void handleUserCommand() {
Command.setAuthenticationMode(auth, userName);
+ if (CommandActions.LIST.equals(command)) {
+ newListUsers(url, ignore, metalake).handle();
+ return;
+ }
+
+ if (Objects.isNull(user)) {
+ System.err.println("User is undefined. Please use --user to specify a
user.");
Review Comment:
I'd keep in line with other error messages and use "Missing --user option."
Even if we were to use more verbose error messages I'd avoid saying "undefined".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
