justinmclean commented on code in PR #5906:
URL: https://github.com/apache/gravitino/pull/5906#discussion_r1893870704
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -381,27 +381,33 @@ private void handleTableCommand() {
String schema = name.getSchemaName();
Command.setAuthenticationMode(auth, userName);
+ List<String> missingEntities =
+ Stream.of(
+ catalog == null ? CommandEntities.CATALOG : null,
+ schema == null ? CommandEntities.SCHEMA : null)
+ .filter(Objects::nonNull)
+ .collect(Collectors.toList());
// Handle CommandActions.LIST action separately as it doesn't require the
`table`
if (CommandActions.LIST.equals(command)) {
- List<String> missingEntities =
- Stream.of(
- metalake == null ? CommandEntities.METALAKE : null,
- catalog == null ? CommandEntities.CATALOG : null,
- schema == null ? CommandEntities.SCHEMA : null)
- .filter(Objects::nonNull)
- .collect(Collectors.toList());
if (!missingEntities.isEmpty()) {
System.err.println(
"Missing required argument(s): " + Joiner.on(",
").join(missingEntities));
- Main.exit(-1);
+ return;
Review Comment:
This should be Main.exit(-1) not return. If this change was because you are
having an issue with the tests, it is likely an issue with your tests, as I
needed to fix up a couple of your previous tests. In tests have Main.exit throw
an exception by setting the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
