tengqm commented on code in PR #5908: URL: https://github.com/apache/gravitino/pull/5908#discussion_r1894773919
########## core/src/main/java/org/apache/gravitino/catalog/EntityCombinedModelVersion.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog; + +import java.util.Collections; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.gravitino.Audit; +import org.apache.gravitino.meta.AuditInfo; +import org.apache.gravitino.meta.ModelVersionEntity; +import org.apache.gravitino.model.ModelVersion; + +public final class EntityCombinedModelVersion implements ModelVersion { + + private final ModelVersion modelVersion; + + private final ModelVersionEntity modelVersionEntity; + + private Set<String> hiddenProperties = Collections.emptySet(); + + private EntityCombinedModelVersion( + ModelVersion modelVersion, ModelVersionEntity modelVersionEntity) { + this.modelVersion = modelVersion; + this.modelVersionEntity = modelVersionEntity; + } + + public static EntityCombinedModelVersion of( + ModelVersion modelVersion, ModelVersionEntity modelVersionEntity) { + return new EntityCombinedModelVersion(modelVersion, modelVersionEntity); + } + + public static EntityCombinedModelVersion of(ModelVersion modelVersion) { + return new EntityCombinedModelVersion(modelVersion, null); + } + + public EntityCombinedModelVersion withHiddenPropertiesSet(Set<String> hiddenProperties) { Review Comment: ```suggestion public EntityCombinedModelVersion withHiddenProperties(Set<String> hiddenProperties) { ``` ########## core/src/main/java/org/apache/gravitino/catalog/EntityCombinedModel.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog; + +import java.util.Collections; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.gravitino.Audit; +import org.apache.gravitino.meta.AuditInfo; +import org.apache.gravitino.meta.ModelEntity; +import org.apache.gravitino.model.Model; + +public final class EntityCombinedModel implements Model { + + private final Model model; + + private final ModelEntity modelEntity; + + private Set<String> hiddenProperties = Collections.emptySet(); + + private EntityCombinedModel(Model model, ModelEntity modelEntity) { + this.model = model; + this.modelEntity = modelEntity; + } + + public static EntityCombinedModel of(Model model, ModelEntity modelEntity) { + return new EntityCombinedModel(model, modelEntity); + } + + public static EntityCombinedModel of(Model model) { + return new EntityCombinedModel(model, null); + } + + public EntityCombinedModel withHiddenPropertiesSet(Set<String> hiddenProperties) { Review Comment: ```suggestion public EntityCombinedModel withHiddenProperties(Set<String> hiddenProperties) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
