mchades commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895155032
##########
docs/open-api/openapi.yaml:
##########
@@ -477,7 +477,21 @@ components:
- "TOPIC"
- "ROLE"
- "METALAKE"
-
+ metadataObjectTypeWithOwner:
Review Comment:
Since this parameter is only used in the owner, please move it to the
`owner.yaml` file.
BTW, how about renaming to `metadataObjectTypeOfOwner` ?
##########
docs/open-api/openapi.yaml:
##########
@@ -477,7 +477,21 @@ components:
- "TOPIC"
- "ROLE"
- "METALAKE"
-
+ metadataObjectTypeWithOwner:
+ name: metadataObjectType
+ in: path
+ description: The type of the metadata object
+ required: true
+ schema:
+ type: string
+ enum:
+ - "CATALOG"
+ - "SCHEMA"
+ - "TABLE"
+ - "FILESET"
+ - "TOPIC"
+ - "ROLE"
+ - "METALAKE"
Review Comment:
plz move`METALAKE` in front of `CATALOG`, as `METALAKE` has a larger scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]