FANNG1 commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1895628014
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperations.java:
##########
@@ -247,6 +265,20 @@ public void testConnection(
hadoopCatalogOperations.testConnection(catalogIdent, type, provider,
comment, properties);
}
+ @Override
+ public Map<String, CredentialContext> getCredentialContexts(
+ NameIdentifier nameIdentifier, CredentialPrivilege privilege) {
+ if
(nameIdentifier.equals(NameIdentifierUtil.getCatalogIdentifier(nameIdentifier)))
{
+ return getCatalogCredentialContexts();
+ }
+ return getFilesetCredentialContexts(nameIdentifier, privilege);
+ }
Review Comment:
The catalog credentials is mainly used for static credentials like AKSK, and
the fileset credential is used for dymatic credentials like S3 tokens, is there
any scenarios about schema credentials?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
