cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896365535
##########
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##########
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEvent {
private final String name;
private final TagChange[] changes;
public AlterTagFailureEvent(String user, String metalake, String name,
TagChange[] changes, Exception exception) {
- super(user, exception);
+ super(user, null, exception);
Review Comment:
I mean, currently TagDispatcher's methods are passing metalake as a String,
and then turn it to NameIdentifier in TagManager.
I'm asking about if I should turn it to NameIdentifier earlier in
TagOperations and then pass it through event and manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
