jerryshao commented on code in PR #5786:
URL: https://github.com/apache/gravitino/pull/5786#discussion_r1897128740
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerPathBaseMetadataObject.java:
##########
@@ -42,17 +42,6 @@ public enum Type implements AuthorizationMetadataObject.Type
{
public MetadataObject.Type metadataObjectType() {
return metadataType;
}
-
- public static RangerHadoopSQLMetadataObject.Type fromMetadataType(
- MetadataObject.Type metadataType) {
- for (RangerHadoopSQLMetadataObject.Type type :
RangerHadoopSQLMetadataObject.Type.values()) {
- if (type.metadataObjectType() == metadataType) {
- return type;
- }
- }
- throw new IllegalArgumentException(
- "No matching RangerMetadataObject.Type for " + metadataType);
- }
}
private final String path;
Review Comment:
Can we rename this class from `RangerPathBaseMetadataObject` to
`RangerPathBasedMetadataObject` or `RangerPathMetadataObject`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
