mchades commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897363327
##########
build.gradle.kts:
##########
@@ -779,7 +779,9 @@ tasks {
!it.name.startsWith("client") && !it.name.startsWith("filesystem") &&
!it.name.startsWith("spark") && !it.name.startsWith("iceberg") && it.name !=
"trino-connector" &&
it.name != "integration-test" && it.name != "bundled-catalog" &&
!it.name.startsWith("flink") &&
it.name != "integration-test" && it.name != "hive-metastore-common" &&
!it.name.startsWith("flink") &&
- it.name != "gcp-bundle" && it.name != "aliyun-bundle" && it.name !=
"aws-bundle" && it.name != "azure-bundle" && it.name != "hadoop-common"
+ it.name != "gcp-bundle" && it.name != "aliyun-bundle" && it.name !=
"aws-bundle" && it.name != "azure-bundle" &&
+ it.name != "aws-hadoop-bundle" && it.name != "gcp-hadoop-bundle" &&
it.name != "azure-hadoop-bundle" && it.name != "aliyun-hadoop-bundle" &&
Review Comment:
In theory, all modules under bundles do not need to copy dependencies.
Can we optimize the judgment condition here so that we can add sub-modules
under bundles later without modifying this judgment condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
