FANNG1 commented on code in PR #5682: URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897544784
########## core/src/main/java/org/apache/gravitino/connector/credential/PathBasedContext.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.connector.credential; + +import org.apache.gravitino.annotation.DeveloperApi; + +/** + * The {@code PathBasedContext} class represents the path and its associated credential type to + * generate a credential for {@link org.apache.gravitino.credential.CredentialOperationDispatcher}. + */ +@DeveloperApi +public class PathBasedContext { + + private final String path; + + private final String credentialType; + + /** + * Constructs a new {@code PathBasedContext} instance with the given path and credential type. + * + * @param path The path string. + * @param credentialType The type of the credential. + */ + public PathBasedContext(String path, String credentialType) { Review Comment: updated ########## core/src/main/java/org/apache/gravitino/credential/CredentialUtils.java: ########## @@ -19,14 +19,74 @@ package org.apache.gravitino.credential; +import com.google.common.base.Splitter; import com.google.common.collect.ImmutableSet; +import java.util.Map; +import java.util.Set; +import java.util.function.Supplier; +import java.util.stream.Collectors; import org.apache.gravitino.utils.PrincipalUtils; public class CredentialUtils { + + private static final Splitter splitter = Splitter.on(","); + public static Credential vendCredential(CredentialProvider credentialProvider, String[] path) { PathBasedCredentialContext pathBasedCredentialContext = new PathBasedCredentialContext( PrincipalUtils.getCurrentUserName(), ImmutableSet.copyOf(path), ImmutableSet.of()); return credentialProvider.getCredential(pathBasedCredentialContext); } + + public static Map<String, CredentialProvider> loadCredentialProviders( + Map<String, String> catalogProperties) { + Set<String> credentialProviders = + CredentialUtils.getCredentialProvidersByOrder(() -> catalogProperties); + + return credentialProviders.stream() + .collect( + Collectors.toMap( + String::toString, + credentialType -> + CredentialProviderFactory.create(credentialType, catalogProperties))); + } + + /** + * Get Credential providers from properties supplier. + * + * <p>If there are multiple properties suppliers, will try to get the credential providers in the + * input order. + * + * @param propertiesSuppliers The properties suppliers. + * @return A set of credential providers. + */ + public static Set<String> getCredentialProvidersByOrder( + Supplier<Map<String, String>>... propertiesSuppliers) { + + for (Supplier<Map<String, String>> supplier : propertiesSuppliers) { + Map<String, String> properties = supplier.get(); + Set<String> providers = getCredentialProvidersFromProperties(properties); + if (!providers.isEmpty()) { + return providers; + } + } + + return ImmutableSet.of(); + } + + private static Set<String> getCredentialProvidersFromProperties(Map<String, String> properties) { + if (properties == null) { + return ImmutableSet.of(); Review Comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
