jerryshao commented on code in PR #6021:
URL: https://github.com/apache/gravitino/pull/6021#discussion_r1899249911
##########
core/src/main/java/org/apache/gravitino/credential/config/CredentialConfig.java:
##########
@@ -67,12 +69,13 @@ public class CredentialConfig extends Config {
false /* reserved */))
.build();
- public static final ConfigEntry<String> CREDENTIAL_PROVIDERS =
+ public static final ConfigEntry<List<String>> CREDENTIAL_PROVIDERS =
new ConfigBuilder(CredentialConstants.CREDENTIAL_PROVIDERS)
.doc("Credential providers, separated by comma.")
.version(ConfigConstants.VERSION_0_8_0)
.stringConf()
- .create();
+ .toSequence()
+ .createWithDefault(Collections.emptyList());
Review Comment:
It's weird that changes to `List` here alone is enough? Do you need to
change to other places that uses this variable, how can they pass the type
check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
