mchades commented on code in PR #6009: URL: https://github.com/apache/gravitino/pull/6009#discussion_r1899277116
########## clients/client-python/gravitino/dto/requests/model_version_link_request.py: ########## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from dataclasses import field, dataclass +from typing import Optional, List, Dict + +from dataclasses_json import config + +from gravitino.exceptions.base import IllegalArgumentException +from gravitino.rest.rest_message import RESTRequest + + +@dataclass +class ModelVersionLinkRequest(RESTRequest): + """Represents a request to link a model version to a model.""" + + _uri: str = field(metadata=config(field_name="uri")) + _comment: Optional[str] = field(metadata=config(field_name="comment")) + _aliases: Optional[List[str]] = field(metadata=config(field_name="aliases")) + _properties: Optional[Dict[str, str]] = field( + metadata=config(field_name="properties") + ) + + def __init__( + self, + uri: str, + comment: Optional[str] = None, + aliases: Optional[List[str]] = None, + properties: Optional[Dict[str, str]] = None, + ): + self._uri = uri + self._comment = comment + self._aliases = aliases + self._properties = properties + + def validate(self): Review Comment: > 2. For the compatibility issue, I think currently we restrict that number string is not allowed for alias, later on when we relief the constraint, the current code still works, there's no compatibility issue. later on when we relief the constraint (or other changes in validation rules) on the server side, if we still keep the validation here, users have to update their python client to apply the changes. (They could have done nothing and just add their new request codes) I'm worried that this may not be user-friendly and convenient enough for users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
