tengqm commented on code in PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#discussion_r1899868114
##########
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##########
@@ -166,6 +168,7 @@ private String createPolicy(Set<String> readLocations,
Set<String> writeLocation
Statement.builder()
.effect(Effect.ALLOW)
.addAction("oss:GetBucketLocation")
+ .addAction("oss:GetBucketInfo")
Review Comment:
Please confirm that it is okay to have two actions added here, and update
the comments accordingly.
##########
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##########
@@ -149,14 +150,15 @@ private String createPolicy(Set<String> readLocations,
Set<String> writeLocation
location -> {
URI uri = URI.create(location);
allowGetObjectStatementBuilder.addResource(getOssUriWithArn(arnPrefix, uri));
+
String bucketArn = arnPrefix + getBucketName(uri);
// ListBucket
bucketListStatementBuilder.computeIfAbsent(
Review Comment:
These are supposed to be revised at well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
