mchades commented on code in PR #6040:
URL: https://github.com/apache/gravitino/pull/6040#discussion_r1899891595
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogCapability.java:
##########
@@ -31,4 +31,19 @@ public CapabilityResult managedStorage(Scope scope) {
return CapabilityResult.unsupported(
String.format("Hadoop catalog does not support managed storage for
%s.", scope));
}
+
+ @Override
+ public CapabilityResult specificationOnName(Scope scope, String name) {
+ CapabilityResult capabilityResult =
Capability.super.specificationOnName(scope, name);
+ if (!capabilityResult.supported()) {
+ return capabilityResult;
+ }
+
+ if (name.contains("/")) {
Review Comment:
What you described is exactly the responsibility of interface `Capability`:
https://github.com/apache/gravitino/blob/9a5fef924ee3488ef99bb00c75913f885a84dff3/core/src/main/java/org/apache/gravitino/connector/capability/Capability.java#L74-L83
which will be implemented by each catalog. It already has a default
implementation with constraints on length and special characters. I think it is
considered strict enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
