tengqm commented on code in PR #6047:
URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899947692
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -494,6 +496,42 @@ private void handleTableCommand() {
}
}
+ /** Handles the command execution for Models based on command type and the
command line options. */
+ private void handleModelCommand() {
+ String url = getUrl();
+ String auth = getAuth();
+ String userName = line.getOptionValue(GravitinoOptions.LOGIN);
+ FullName name = new FullName(line);
+ String metalake = name.getMetalakeName();
+ String catalog = name.getCatalogName();
+
+ Command.setAuthenticationMode(auth, userName);
+ List<String> missingEntities = Lists.newArrayList();
+ if (metalake == null) missingEntities.add(CommandEntities.METALAKE);
+ if (catalog == null) missingEntities.add(CommandEntities.CATALOG);
+
+ // TODO: Add remaining commands to TestableCommandLine
+ String model = name.getModelName();
+ if (model == null) {
+ missingEntities.add(CommandEntities.MODEL);
Review Comment:
Agreed. Let's keep the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
