tengqm commented on code in PR #6045:
URL: https://github.com/apache/gravitino/pull/6045#discussion_r1900043958
##########
core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java:
##########
@@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) {
@Override
public boolean dropCatalog(NameIdentifier ident, boolean force)
throws NonEmptyEntityException, CatalogInUseException {
- AuthorizationUtils.authorizationPluginRemovePrivileges(ident,
Entity.EntityType.CATALOG);
- return dispatcher.dropCatalog(ident, force);
+ // If we call the authorization plugin after dropping catalog, we can't
load the plugin of the
+ // catalog
+ Runnable removePrivilegesCallback = null;
+ if (dispatcher.catalogExists(ident)) {
+ removePrivilegesCallback =
+ AuthorizationUtils.createRemovePrivilegesCallback(ident,
Entity.EntityType.CATALOG);
+ }
+
+ boolean dropped = dispatcher.dropCatalog(ident, force);
+
+ if (dropped && removePrivilegesCallback != null) {
+ removePrivilegesCallback.run();
+ }
Review Comment:
So... let's put aside my suggestions on using names/ids for post-deletion
operations or similar outcalls.
If the catalog objects are still valid, why don't we just use the objects?
```none
catalogs = loadCatalogs(ident);
bSuccess = dropCatalogs(ident, force);
if (bSuccess) callAuthorizationPlugin(..., catalogs);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
