tengqm commented on code in PR #6066:
URL: https://github.com/apache/gravitino/pull/6066#discussion_r1900825260
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -1183,6 +1185,38 @@ private void handleModelCommand() {
newModelDetails(url, ignore, metalake, catalog, schema,
model).handle();
break;
+ case CommandActions.CREATE:
+ String createComment = line.getOptionValue(GravitinoOptions.COMMENT);
+ String[] createProperties =
line.getOptionValues(GravitinoOptions.PROPERTIES);
+ Map<String, String> createPropertyMap = new
Properties().parse(createProperties);
+ newCreateModel(
+ url, ignore, metalake, catalog, schema, model, createComment,
createPropertyMap)
+ .handle();
+ break;
+
+ case CommandActions.UPDATE:
+ if (uri == null) {
Review Comment:
Where are we documenting whether an argument is required or not?
Do we have a formal spec, e.g. OpenAPI or Swagger thing?
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java:
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.cli.commands;
+
+import java.util.Map;
+import org.apache.gravitino.NameIdentifier;
+import org.apache.gravitino.cli.ErrorMessages;
+import org.apache.gravitino.client.GravitinoClient;
+import org.apache.gravitino.exceptions.ModelAlreadyExistsException;
+import org.apache.gravitino.exceptions.NoSuchCatalogException;
+import org.apache.gravitino.exceptions.NoSuchMetalakeException;
+import org.apache.gravitino.exceptions.NoSuchSchemaException;
+import org.apache.gravitino.model.Model;
+import org.apache.gravitino.model.ModelCatalog;
+
+/** Register a model in the catalog */
+public class RegisterModel extends Command {
+
+ protected final String metalake;
+ protected final String catalog;
+ protected final String schema;
+ protected final String model;
+ protected final String comment;
+ protected final Map<String, String> properties;
+
+ /**
+ * Register a model in the catalog
+ *
+ * @param url The URL of the Gravitino server.
+ * @param ignoreVersions If true don't check the client/server versions
match.
+ * @param metalake The name of the metalake.
+ * @param catalog The name of the catalog.
+ * @param schema The name of schema.
+ * @param model The name of model.
+ * @param comment The comment of the model version.
+ * @param properties The properties of the model version.
+ */
+ public RegisterModel(
+ String url,
+ boolean ignoreVersions,
+ String metalake,
+ String catalog,
+ String schema,
+ String model,
+ String comment,
+ Map<String, String> properties) {
+ super(url, ignoreVersions);
+ this.metalake = metalake;
+ this.catalog = catalog;
+ this.schema = schema;
+ this.model = model;
+ this.comment = comment;
+ this.properties = properties;
+ }
+
+ /** Register a model in the catalog */
+ @Override
+ public void handle() {
+ NameIdentifier name = NameIdentifier.of(schema, model);
+ Model registeredModel = null;
+
+ try {
+ GravitinoClient client = buildClient(metalake);
+ ModelCatalog modelCatalog = client.loadCatalog(catalog).asModelCatalog();
+ registeredModel = modelCatalog.registerModel(name, comment, properties);
+ } catch (NoSuchMetalakeException err) {
+ exitWithError(ErrorMessages.UNKNOWN_METALAKE);
+ } catch (NoSuchCatalogException err) {
+ exitWithError(ErrorMessages.UNKNOWN_CATALOG);
+ } catch (NoSuchSchemaException err) {
+ exitWithError(ErrorMessages.UNKNOWN_SCHEMA);
+ } catch (ModelAlreadyExistsException err) {
+ exitWithError(ErrorMessages.MODEL_EXISTS);
+ } catch (Exception err) {
+ exitWithError(err.getMessage());
+ }
+
+ if (registeredModel != null) {
+ System.out.println("Successful register " + registeredModel.name() +
".");
+ } else {
+ System.err.println("Failed to register model: " + model + ".");
+ }
Review Comment:
Two confusions here:
- Do we have a protocol regarding where to output error/info messages?
- Are we always printing something on the command line when some actions
were successful?
I am thinking of a scenario where the command line tool is invoked from an
upper
layer script. Getting this verbose message are not so "helpful" as we expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
