orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901455459
########## docs/hadoop-catalog.md: ########## @@ -166,6 +178,9 @@ Refer to [Schema operation](./manage-fileset-metadata-using-gravitino.md#schema- | `authentication.type` | The type of authentication for Hadoop catalog fileset, currently we only support `kerberos`, `simple`. | The parent(schema) value | No | 0.6.0-incubating | | `authentication.kerberos.principal` | The principal of the Kerberos authentication for the fileset. | The parent(schema) value | No | 0.6.0-incubating | | `authentication.kerberos.keytab-uri` | The URI of The keytab for the Kerberos authentication for the fileset. | The parent(schema) value | No | 0.6.0-incubating | +| `credential-providers` | The credential provider types, separated by comma. | (none) | No | 0.8.0-incubating | + +The credential providers in fileset properties will overwrite the credential providers in schema properties and catalog properties, if not set, the credential providers in schema properties will be used, if the credential providers in schema properties are not set, will use the credential providers in catalog properties. Review Comment: I think the original explanation might be a bit difficult to understand at first glance. How about rephrasing it like this? ```markdown Credential providers are applied in the following order of precedence: 1. **Fileset properties** override all other settings. 2. If not set in **fileset properties**, **schema properties** are used. 3. If not set in **schema properties**, **catalog properties** are used. ``` @tengqm What do you think about this version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
