FANNG1 commented on code in PR #5997:
URL: https://github.com/apache/gravitino/pull/5997#discussion_r1901531443
##########
clients/client-python/gravitino/api/credential/adls_token_credential.py:
##########
@@ -27,12 +27,12 @@ class ADLSTokenCredential(Credential, ABC):
ADLS_TOKEN_CREDENTIAL_TYPE: str = "adls-token"
ADLS_DOMAIN: str = "dfs.core.windows.net"
- _STORAGE_ACCOUNT_NAME: str = "azure-storage-account-name"
- _SAS_TOKEN: str = "adls-sas-token"
+ STORAGE_ACCOUNT_NAME: str = "azure-storage-account-name"
Review Comment:
please don't use the internal `STORAGE_ACCOUNT_NAME` properties directly.
seem to other credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
