jerqi commented on code in PR #6045:
URL: https://github.com/apache/gravitino/pull/6045#discussion_r1903621807
##########
core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java:
##########
@@ -126,8 +126,19 @@ public boolean dropCatalog(NameIdentifier ident) {
@Override
public boolean dropCatalog(NameIdentifier ident, boolean force)
throws NonEmptyEntityException, CatalogInUseException {
- AuthorizationUtils.authorizationPluginRemovePrivileges(ident,
Entity.EntityType.CATALOG);
- return dispatcher.dropCatalog(ident, force);
+ // If we call the authorization plugin after dropping catalog, we can't
load the plugin of the
+ // catalog
+ Catalog catalog = null;
+ if (dispatcher.catalogExists(ident)) {
+ catalog = dispatcher.loadCatalog(ident);
+ }
Review Comment:
Thanks for your suggestion. I got your concern. It's a bigger topic. For
this pull request, I will the semantic as community discussed before. You can
discuss this topic in https://github.com/apache/gravitino/issues/5031 if you
have concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
