yuqi1129 commented on code in PR #5997: URL: https://github.com/apache/gravitino/pull/5997#discussion_r1904838263
########## clients/client-python/tests/integration/test_gvfs_with_gcs_credential.py: ########## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import os +from random import randint +import unittest + +from gcsfs import GCSFileSystem + +from gravitino import Catalog, Fileset, GravitinoClient +from gravitino.filesystem import gvfs +from tests.integration.test_gvfs_with_gcs import TestGvfsWithGCS + +logger = logging.getLogger(__name__) + + +def gcs_with_credential_is_configured(): + return all( + [ + os.environ.get("GCS_STS_SERVICE_ACCOUNT_JSON_PATH") is not None, + os.environ.get("GCS_STS_BUCKET_NAME") is not None, + ] + ) + + [email protected](gcs_with_credential_is_configured(), "GCS is not configured.") +class TestGvfsWithGCSCredential(TestGvfsWithGCS): + # Before running this test, please set the make sure gcp-bundle-x.jar has been + # copy to the $GRAVITINO_HOME/catalogs/hadoop/libs/ directory + key_file = os.environ.get("GCS_STS_SERVICE_ACCOUNT_JSON_PATH") + bucket_name = os.environ.get("GCS_STS_BUCKET_NAME") + metalake_name: str = "TestGvfsWithGCSCredential_metalake" + str(randint(1, 10000)) + + @classmethod + def _init_test_entities(cls): + cls.gravitino_admin_client.create_metalake( + name=cls.metalake_name, comment="", properties={} + ) + cls.gravitino_client = GravitinoClient( + uri="http://localhost:8090";, metalake_name=cls.metalake_name + ) + + cls.config = {} + cls.conf = {} + catalog = cls.gravitino_client.create_catalog( + name=cls.catalog_name, + catalog_type=Catalog.Type.FILESET, + provider=cls.catalog_provider, + comment="", + properties={ + "filesystem-providers": "gcs", + "gcs-credential-file-path": cls.key_file, + "gcs-service-account-file": cls.key_file, + "credential-providers": "gcs-token", + }, + ) + catalog.as_schemas().create_schema( + schema_name=cls.schema_name, comment="", properties={} + ) + + cls.fileset_storage_location: str = ( + f"gs://{cls.bucket_name}/{cls.catalog_name}/{cls.schema_name}/{cls.fileset_name}" + ) + cls.fileset_gvfs_location = ( + f"gvfs://fileset/{cls.catalog_name}/{cls.schema_name}/{cls.fileset_name}" + ) + catalog.as_fileset_catalog().create_fileset( + ident=cls.fileset_ident, + fileset_type=Fileset.Type.MANAGED, + comment=cls.fileset_comment, + storage_location=cls.fileset_storage_location, + properties=cls.fileset_properties, + ) + + cls.fs = GCSFileSystem(token=cls.key_file) + + def test_mkdir(self): Review Comment: I can add some description about the detailed reason, not only `mkdir`, other operation like `makedirs`, `ls` also have similar issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
