mchades commented on code in PR #6059:
URL: https://github.com/apache/gravitino/pull/6059#discussion_r1904871775
##########
docs/how-to-use-gvfs.md:
##########
@@ -68,51 +71,51 @@ Apart from the above properties, to access fileset like S3,
GCS, OSS and custom
#### S3 fileset
-| Configuration item | Description | Default value |
Required | Since version |
-|------------------------|-------------------------------|---------------|---------------------------|------------------|
-| `s3-endpoint` | The endpoint of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
-| `s3-access-key-id` | The access key of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
-| `s3-secret-access-key` | The secret key of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
+| Configuration item | Description | Default value |
Required | Since version |
+|------------------------|-------------------------------|---------------|--------------------------|------------------|
+| `s3-endpoint` | The endpoint of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
+| `s3-access-key-id` | The access key of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
+| `s3-secret-access-key` | The secret key of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
At the same time, you need to add the corresponding bundle jar
-1.
[`gravitino-aws-bundle-${version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws-bundle/)
in the classpath if no hadoop environment is available, or
-2.
[`gravitino-aws-${version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws/)
and hadoop-aws jar and other necessary dependencies in the classpath.
+1.
[`gravitino-aws-bundle-${gravitino-version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws-bundle/)
in the classpath if no Hadoop environment is available, or
+2.
[`gravitino-aws-${gravitino-version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws/)
and `hadoop-aws-${hadoop-version}.jar` and other necessary dependencies (They
are usually located at `${HADOOP_HOME}/share/hadoop/tools/lib`) in the
classpath.
#### GCS fileset
-| Configuration item | Description |
Default value | Required | Since version |
-|----------------------------|--------------------------------------------|---------------|----------------------------|------------------|
-| `gcs-service-account-file` | The path of GCS service account JSON file. |
(none) | Yes if it's a GCS fileset. | 0.7.0-incubating |
+| Configuration item | Description |
Default value | Required | Since version |
+|----------------------------|--------------------------------------------|---------------|---------------------------|------------------|
+| `gcs-service-account-file` | The path of GCS service account JSON file. |
(none) | Yes if it's a GCS fileset.| 0.7.0-incubating |
Review Comment:
Yes if it's a GCS fileset. -> Yes
Because you are in paragraph `GCS fileset`
##########
docs/how-to-use-gvfs.md:
##########
@@ -68,51 +71,51 @@ Apart from the above properties, to access fileset like S3,
GCS, OSS and custom
#### S3 fileset
-| Configuration item | Description | Default value |
Required | Since version |
-|------------------------|-------------------------------|---------------|---------------------------|------------------|
-| `s3-endpoint` | The endpoint of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
-| `s3-access-key-id` | The access key of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
-| `s3-secret-access-key` | The secret key of the AWS S3. | (none) | Yes
if it's a S3 fileset. | 0.7.0-incubating |
+| Configuration item | Description | Default value |
Required | Since version |
+|------------------------|-------------------------------|---------------|--------------------------|------------------|
+| `s3-endpoint` | The endpoint of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
+| `s3-access-key-id` | The access key of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
+| `s3-secret-access-key` | The secret key of the AWS S3. | (none) | Yes
if it's a S3 fileset.| 0.7.0-incubating |
At the same time, you need to add the corresponding bundle jar
-1.
[`gravitino-aws-bundle-${version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws-bundle/)
in the classpath if no hadoop environment is available, or
-2.
[`gravitino-aws-${version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws/)
and hadoop-aws jar and other necessary dependencies in the classpath.
+1.
[`gravitino-aws-bundle-${gravitino-version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gravitino-aws-bundle/)
in the classpath if no Hadoop environment is available, or
Review Comment:
the link is invalid now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
