yuqi1129 commented on code in PR #5997:
URL: https://github.com/apache/gravitino/pull/5997#discussion_r1906592946


##########
clients/client-python/gravitino/filesystem/gvfs_config.py:
##########
@@ -44,3 +44,8 @@ class GVFSConfig:
 
     GVFS_FILESYSTEM_AZURE_ACCOUNT_NAME = "abs_account_name"
     GVFS_FILESYSTEM_AZURE_ACCOUNT_KEY = "abs_account_key"
+
+    # This configuration marks the expired time of the credential. For 
instance, if the credential
+    # fetched from Gravitino server has expired time of 3600 seconds, and the 
credential_expired_time_ration is 0.5
+    # then the credential will be considered as expired after 1800 seconds and 
will try to fetch a new credential.
+    GVFS_FILESYSTEM_CREDENTIAL_EXPIRED_TIME_RATIO = 
"credential_expired_time_ratio"

Review Comment:
   There is already a configuration item `cache_expired_time` to control the 
expiration time of the value in the cache, I'm not very in favor of 
`credential_cache_expire_ratio`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to