FANNG1 commented on code in PR #6160:
URL: https://github.com/apache/gravitino/pull/6160#discussion_r1908845828
##########
.github/workflows/gvfs-fuse-build-test.yml:
##########
@@ -71,10 +71,17 @@ jobs:
run: |
dev/ci/check_commands.sh
- - name: Build and test Gravitino
+ - name: Build and test Gvfs-fuse
run: |
./gradlew :clients:filesystem-fuse:build -PenableFuse=true
+ - name: Integration test
+ run: |
+ ./gradlew bundles:aws-bundle:build -x :clients:client-python:build
compileDistribution -x test -x web -PjdkVersion=${{ matrix.java-version }}
Review Comment:
it's hard to use, use `make prepare-it-env` ?
##########
clients/filesystem-fuse/src/gravitino_client.rs:
##########
@@ -35,6 +35,18 @@ pub(crate) struct Fileset {
properties: HashMap<String, String>,
}
+impl Fileset {
+ pub fn new(name: &str, storage_location: &str) -> Fileset {
+ Self {
+ name: name.to_string(),
+ fileset_type: "managed".to_string(),
Review Comment:
do we support non managed fileset?
##########
clients/filesystem-fuse/Makefile:
##########
@@ -62,6 +62,12 @@ doc-test:
unit-test: doc-test
cargo test --no-fail-fast --lib --all-features --workspace
+test-fuse:
+ @bash ./tests/bin/s3_fileset_it.sh test
+
+test-s3:
Review Comment:
it's hard to understand the test from the name, use better name?
##########
clients/filesystem-fuse/src/gravitino_client.rs:
##########
@@ -58,6 +70,18 @@ pub(crate) struct Catalog {
pub(crate) properties: HashMap<String, String>,
}
+impl Catalog {
+ pub fn new(name: &str, properties: HashMap<String, String>) -> Catalog {
Review Comment:
rename to `new_fileset_with_s3` or move `catalog_type`, `provider` to the
parameters?
##########
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##########
@@ -334,13 +334,21 @@ impl<T: PathFileSystem> RawFileSystem for
DefaultRawFileSystem<T> {
file.flush().await
}
- async fn close_file(&self, _file_id: u64, fh: u64) -> Result<()> {
+ async fn close_file(&self, file_id: u64, fh: u64) -> Result<()> {
+ let file_entry = self.get_file_entry(file_id).await;
Review Comment:
why adding this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
