FANNG1 commented on code in PR #6160:
URL: https://github.com/apache/gravitino/pull/6160#discussion_r1910045102
##########
clients/filesystem-fuse/src/gravitino_fileset_filesystem.rs:
##########
@@ -172,4 +183,68 @@ mod tests {
let path =
fs.raw_path_to_gvfs_path(Path::new("/c1/fileset1")).unwrap();
assert_eq!(path, Path::new("/"));
}
+
+ async fn create_fileset_fs(path: &Path, config: &AppConfig) ->
GravitinoFilesetFileSystem {
+ let opendal_config = extract_s3_config(config);
+
+ cleanup_s3_fs(path, &opendal_config).await;
+
+ let bucket = opendal_config.get("bucket").expect("Bucket must exist");
+ let endpoint = opendal_config.get("endpoint").expect("Endpoint must
exist");
+
+ let catalog = create_test_catalog(
+ "c1",
+ "s3",
+ vec![
+ ("location".to_string(), format!("s3a://{}", bucket)),
+ ("s3-endpoint".to_string(), endpoint.to_string()),
+ ]
+ .into_iter()
+ .collect::<HashMap<String, String>>(),
+ );
+ let file_set_location = format!("s3a://{}{}", bucket,
path.to_string_lossy());
+ let file_set = create_test_fileset("fileset1", &file_set_location);
+
+ let fs_context = FileSystemContext::default();
+ let inner_fs = create_fs_with_fileset(&catalog, &file_set, config,
&fs_context)
+ .await
+ .unwrap();
+ GravitinoFilesetFileSystem::new(
+ inner_fs,
+ path,
+ GravitinoClient::new(&config.gravitino),
+ config,
+ &fs_context,
+ )
+ .await
+ }
+
+ #[tokio::test]
+ async fn s3_ut_test_fileset_file_system() {
Review Comment:
this seems an IT not UT? and could you place IT in separate files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
