FANNG1 commented on code in PR #6231:
URL: https://github.com/apache/gravitino/pull/6231#discussion_r1914667973


##########
docs/hadoop-catalog-with-adls.md:
##########
@@ -480,11 +480,31 @@ For other use cases, please refer to the [Gravitino 
Virtual File System](./how-t
 
 Since 0.8.0-incubating, Gravitino supports credential vending for ADLS 
fileset. If the catalog has been [configured with 
credential](./security/credential-vending.md), you can access ADLS fileset 
without providing authentication information like `azure-storage-account-name` 
and `azure-storage-account-key` in the properties.
 
-### How to create an ADLS Hadoop catalog with credential enabled
+### How to create an ADLS Hadoop catalog with credential vending
 
-Apart from configuration method in 
[create-adls-hadoop-catalog](#configuration-for-a-adls-hadoop-catalog), 
properties needed by 
[adls-credential](./security/credential-vending.md#adls-credentials) should 
also be set to enable credential vending for ADLS fileset.
+Apart from configuration method in 
[create-adls-hadoop-catalog](#configuration-for-a-adls-hadoop-catalog), 
properties needed by 
[adls-credential](./security/credential-vending.md#adls-credentials) should 
also be set to enable credential vending for ADLS fileset. Take `adls-token` 
credential provider for example:
 
-### How to access ADLS fileset with credential
+```shell

Review Comment:
   If we mix the example with the example without credentials, it will be hard 
to distinguish them especially in fileset client side



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to