hdygxsj commented on code in PR #6224:
URL: https://github.com/apache/gravitino/pull/6224#discussion_r1915860369
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java:
##########
@@ -72,6 +72,10 @@ protected boolean
supportSchemaOperationWithCommentAndOptions() {
return true;
}
+ protected Map<String, String> schemaOptions(String warehouse, String
schemaName) {
Review Comment:
Some catalogs require additional options to be filled out, such as
PaimonJdbcCatalog.
```java
protected void createDatabaseImpl(String name, Map<String, String>
properties) {
if (this.databaseExists(name)) {
throw new RuntimeException(String.format("Database already
exists: %s", name));
} else {
Map<String, String> createProps = new HashMap();
createProps.put("exists", "true");
if (properties != null && !properties.isEmpty()) {
createProps.putAll(properties);
}
if (!createProps.containsKey("location")) {
Path databasePath = this.newDatabasePath(name);
createProps.put("location", databasePath.toString());
}
JdbcUtils.insertProperties(this.connections, this.catalogKey,
name, createProps);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
