justinmclean commented on code in PR #6240:
URL: https://github.com/apache/gravitino/pull/6240#discussion_r1915928172
##########
clients/cli/src/main/java/org/apache/gravitino/cli/UserCommandHandler.java:
##########
@@ -150,14 +150,23 @@ private void handleDeleteCommand() {
/** Handles the "REVOKE" command. */
private void handleRevokeCommand() {
- String[] revokeRoles = line.getOptionValues(GravitinoOptions.ROLE);
- for (String role : revokeRoles) {
- this.gravitinoCommandLine
- .newRemoveRoleFromUser(this.url, this.ignore, this.metalake, user,
role)
+ boolean removeAll = line.hasOption(GravitinoOptions.ALL);
+ if (removeAll) {
+ gravitinoCommandLine
+ .newRemoveAllRoles(url, ignore, metalake, user, CommandEntities.USER)
.validate()
.handle();
+ System.out.printf("Remove all roles from user %s%n", user);
Review Comment:
same here
##########
clients/cli/src/main/java/org/apache/gravitino/cli/UserCommandHandler.java:
##########
@@ -150,14 +150,23 @@ private void handleDeleteCommand() {
/** Handles the "REVOKE" command. */
private void handleRevokeCommand() {
- String[] revokeRoles = line.getOptionValues(GravitinoOptions.ROLE);
- for (String role : revokeRoles) {
- this.gravitinoCommandLine
- .newRemoveRoleFromUser(this.url, this.ignore, this.metalake, user,
role)
+ boolean removeAll = line.hasOption(GravitinoOptions.ALL);
+ if (removeAll) {
+ gravitinoCommandLine
+ .newRemoveAllRoles(url, ignore, metalake, user, CommandEntities.USER)
.validate()
.handle();
+ System.out.printf("Remove all roles from user %s%n", user);
+ } else {
+ String[] revokeRoles = line.getOptionValues(GravitinoOptions.ROLE);
+ for (String role : revokeRoles) {
+ this.gravitinoCommandLine
+ .newRemoveRoleFromUser(this.url, this.ignore, this.metalake, user,
role)
+ .validate()
+ .handle();
+ }
+ System.out.printf("Remove roles %s from user %s%n",
COMMA_JOINER.join(revokeRoles), user);
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
