FANNG1 commented on code in PR #6248:
URL: https://github.com/apache/gravitino/pull/6248#discussion_r1916819293


##########
docs/security/credential-vending.md:
##########
@@ -53,6 +53,7 @@ An S3 token is a token credential with scoped privileges, by 
leveraging STS [Ass
 | `s3-access-key-id`                  | 
`gravitino.iceberg-rest.s3-access-key-id`          | The static access key ID 
used to access S3 data.                                                         
                                                   | (none)        | Yes      | 
0.6.0-incubating |
 | `s3-secret-access-key`              | 
`gravitino.iceberg-rest.s3-secret-access-key`      | The static secret access 
key used to access S3 data.                                                     
                                                   | (none)        | Yes      | 
0.6.0-incubating |
 | `s3-role-arn`                       | `gravitino.iceberg-rest.s3-role-arn`   
            | The ARN of the role to access the S3 data.                        
                                                                                
          | (none)        | Yes      | 0.7.0-incubating |
+| `s3-region`                         | `gravitino.iceberg-rest.s3-region`     
            | The region of the S3 service, like `us-west-2`.                   
                                                                                
          | (none)        | No       | 0.6.0-incubating |

Review Comment:
   No,  there is another configuraion for STS endpoint



##########
docs/security/credential-vending.md:
##########
@@ -53,6 +53,7 @@ An S3 token is a token credential with scoped privileges, by 
leveraging STS [Ass
 | `s3-access-key-id`                  | 
`gravitino.iceberg-rest.s3-access-key-id`          | The static access key ID 
used to access S3 data.                                                         
                                                   | (none)        | Yes      | 
0.6.0-incubating |
 | `s3-secret-access-key`              | 
`gravitino.iceberg-rest.s3-secret-access-key`      | The static secret access 
key used to access S3 data.                                                     
                                                   | (none)        | Yes      | 
0.6.0-incubating |
 | `s3-role-arn`                       | `gravitino.iceberg-rest.s3-role-arn`   
            | The ARN of the role to access the S3 data.                        
                                                                                
          | (none)        | Yes      | 0.7.0-incubating |
+| `s3-region`                         | `gravitino.iceberg-rest.s3-region`     
            | The region of the S3 service, like `us-west-2`.                   
                                                                                
          | (none)        | No       | 0.6.0-incubating |

Review Comment:
   No,  there is another configuration for STS endpoint



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to